Enable strict typing in req_file.py #8544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deveshks
reviewed
Jul 5, 2020
deveshks
reviewed
Jul 5, 2020
sbidoul
force-pushed
the
req_file-typing-sbi
branch
from
53e6284 to
df79ae4
Compare
|
Thanks for the review @deveshks |
Oh boi. I'm curious how you think this would work -- I'll try to avoid saying much without a concrete proposal for why and how. :) |
pradyunsg
approved these changes
Jul 5, 2020
I'll come to it, eventually :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4748
Plus a docstring typo.
(I came to doing this because I'm toying with requirements file parsing and wondering if
req_file.pycould be exposed as a standalone library, maintained by pip maintainers)