[fast-deps] Make range requests closer to chunk size #8681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just added the news file as trivial. @pradyunsg, is it possible for this to land as part of 20.2.1? |
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Aug 4, 2020
[fast-deps] Make range requests closer to chunk size
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the discovery in #8670 (comment). It is pretty stably reproducible on my network, I've run the before-after
pip install tensorflowwith early exit right after new resolver resolution for 3 times and the execution duration is consistent (30–31s before and 19.5–20s after patching).Regarding the news file, I'm thinking about marking this as trivial since the feature is rather experimental and I am not entirely sure if this always make it faster for all requirement sets. If this can be merged before the bugfix release it would be nice too!