Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Sphinx to v3.2.1 and fix docs build issues #8791

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Bump Sphinx to v3.2.1 and fix docs build issues #8791

merged 3 commits into from
Aug 24, 2020

Conversation

shireenrao
Copy link
Contributor

@shireenrao shireenrao commented Aug 20, 2020 •
edited
Loading

This is to resolve #8781 build issues.

@shireenrao shireenrao changed the title Bump Sphinx to v3.1.2 and fix docs build issues Bump Sphinx to v3.2.1 and fix docs build issues Aug 20, 2020
McSinyx
McSinyx approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@McSinyx McSinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval isn't authoritative but I would love to see this merged as soon as possible. I notice that the code blocks' background are no longer in asparagus color but I suppose it could wait for a follow-up.

@shireenrao
Copy link
Contributor Author

My approval isn't authoritative but I would love to see this merged as soon as possible. I notice that the code blocks' background are no longer in asparagus color but I suppose it could wait for a follow-up.

@McSinyx - Sphinx added background colors and text colors for code blocks as a theme option. I have added that to conf.py and tested locally. The colors are back.

@uranusjr uranusjr mentioned this pull request Aug 24, 2020
Merged
@pradyunsg pradyunsg closed this Aug 24, 2020
@pradyunsg pradyunsg reopened this Aug 24, 2020
@pradyunsg pradyunsg merged commit ffbe932 into pypa:master Aug 24, 2020
@pradyunsg
Copy link
Member

Let's see what CI says on master now. :)

@shireenrao shireenrao deleted the sphinx-upg branch August 24, 2020 12:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@McSinyx McSinyx McSinyx approved these changes

@eamanu eamanu eamanu approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shireenrao @pradyunsg @uranusjr @eamanu @McSinyx