Fix new resolver upgrades when not needed to #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The local logic looks good to me. Would you be able to check what would pip do when a system package does need to upgrade? |
uranusjr
reviewed
Oct 9, 2020
NoahGorny
force-pushed
the
fix-new-resolver-upgrades-when-not-needed-to
branch
from
2ec4e37
to
7e02958
Compare
It works as expected, installing the new version and not removing the old version |
uranusjr
approved these changes
Oct 10, 2020
|
I took the liberty to add this to the 20.3 milestone. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8963
Seems like the new resolver did not get the already installed requirements correctly...
I changed it to the way it works in
_search_distributioninmisc.py:489I did not add tests, as I am not sure what is the correct way to test this