Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Python 3.9 on Travis CI #9015

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Test against Python 3.9 on Travis CI #9015

merged 1 commit into from
Oct 30, 2020

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Oct 19, 2020

Continue stabbing at GH-8967 (yes I'm craving for violence tonight!). Marked as draft until Travis is ready.

@McSinyx McSinyx marked this pull request as ready for review October 28, 2020 14:05
@McSinyx
Copy link
Contributor Author

McSinyx commented Oct 30, 2020

I think this can be merged now. I still can't figure out what @pypa-bot wants so probably a maintainer needs to flag this as trivial.

@pfmoore
Copy link
Member

pfmoore commented Oct 30, 2020

At least one of the changes to test on 3.9 probably deserves a proper news entry. But it doesn't have to be this one. You can add a "trivial" news file, or I can add the label, but let's work out which PR will get the news entry before we accidentally mark them all as trivial 🙂

@pradyunsg
Copy link
Member

There is a "trivial" file in the news/ directory of this PR, and looking at the bot's logs, I'm still not sure why things aren't working.

@pfmoore pfmoore added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 30, 2020
@pfmoore
Copy link
Member

pfmoore commented Oct 30, 2020

Sorry, so there is. I can't see the bot logs, so I don't know. Maybe some sort of timing over the recent change to require a .rst suffix on trivial news files?

I've added the label and will merge. But we should still make sure that #8967 gets a news entry somewhere.

@pfmoore pfmoore merged commit 58d8c2d into pypa:master Oct 30, 2020
@McSinyx
Copy link
Contributor Author

McSinyx commented Oct 30, 2020

Thanks, and is the following enough?

Support Python 3.9.

When I wrote it I noticed that for introduction for support of past CPython version are quite brief also, e.g. the one for py38.

@McSinyx McSinyx deleted the travis39 branch October 30, 2020 10:14
@pfmoore
Copy link
Member

pfmoore commented Oct 30, 2020

Yes, something brief is reasonable. I would go with something like "Add 3.9 to the versions tested in CI", to be explicit that it's about CI.

@McSinyx
Copy link
Contributor Author

McSinyx commented Oct 30, 2020

I assume that we should use the process news fragment, is that correct? Yes I've been waiting for a chance to use it since forever!

@pfmoore
Copy link
Member

pfmoore commented Oct 30, 2020

I knew there was a process one, but when I looked I couldn't see it mentioned. Yes, that's the one to use.

@McSinyx
Copy link
Contributor Author

McSinyx commented Nov 2, 2020

I've added the news fragment to GH-9013.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants