Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore --build-dir #9198

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Restore --build-dir #9198

merged 1 commit into from
Dec 2, 2020

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Dec 1, 2020

Closes #9193

@sbidoul sbidoul added this to the 20.3.1 milestone Dec 1, 2020
@sbidoul sbidoul mentioned this pull request Dec 1, 2020
Closed
@pradyunsg
Copy link
Member

Huraah! Thanks for picking this up!

Also, nit-pick/pet-peeve - I like to avoid mentioning issues in commit messages in a way that Github would create a link-back, because it gets very noisy when rebasing a PR, especially if it's long-standing for some reason.

@sbidoul
Copy link
Member Author

sbidoul commented Dec 1, 2020

avoid mentioning issues in commit messages

Done.

uranusjr
uranusjr reviewed Dec 2, 2020
View reviewed changes
src/pip/_internal/cli/base_command.py
"use the TMPDIR/TEMP/TMP environment variable, "
"possibly combined with --no-clean"
),
gone_in="21.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 21.0 instead? I don’t imagine PyCharm would need more than three months to release an upgrade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They requested 6 months in the issue.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranusjr We've already released upgrades of the IDE, but we'd like to have at least one extra release cycle before the option is removed so that most of them have updated naturally, not because something had broken down. Sorry for causing all this hassle, and postponing a long-expected refactoring in your codebase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@pradyunsg pradyunsg merged commit 30eeb9c into pypa:master Dec 2, 2020
@sbidoul sbidoul deleted the restore-build-dir-sbi branch December 2, 2020 07:37
@pradyunsg pradyunsg modified the milestones: 20.3.2, 20.3.1 Dec 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@east825 east825 east825 left review comments

@uranusjr uranusjr uranusjr left review comments

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.3.1
Development

Successfully merging this pull request may close these issues.

Temporarily restore --build-dir for PyCharm
5 participants
@sbidoul @pradyunsg @uranusjr @east825 @pfmoore