Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop mock test dependency #9377

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Drop mock test dependency #9377

merged 1 commit into from
Feb 27, 2021

Conversation

jdufresne
Copy link
Contributor

@jdufresne jdufresne commented Dec 27, 2020 •
edited
Loading

No description provided.

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Dec 27, 2020
uranusjr
uranusjr reviewed Dec 27, 2020
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 18, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 19, 2021
@jdufresne jdufresne changed the title Drop mock in favor of stdlib unittest.mock Drop mock test dependency Feb 19, 2021
@jdufresne jdufresne mentioned this pull request Feb 19, 2021
Merged
@uranusjr
Copy link
Member

Travis error is unrelated (failed to set up the lint job).

pradyunsg
pradyunsg approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that was easy. :)

@pradyunsg pradyunsg merged commit 68e13c8 into pypa:master Feb 27, 2021
@jdufresne jdufresne deleted the mock branch February 27, 2021 21:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdufresne @BrownTruck @uranusjr @pradyunsg @pypa-bot