Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid downloading multiple candidates of a same version #9432

Merged
merged 1 commit into from
Jan 11, 2021

Commits on Jan 6, 2021

  1. Avoid downloading candidates of a same version

    Since 41a3008, Candidate objects prepare their underlying
    distribution eagerly on creation, so the error can be caught
    deterministically to trigger backtracking.
    
    This however has a negative side-effect. Since dist preparation involves
    metadata validation, a remote distribution must be downloaded on
    Candidate creation. This means that an sdist will be downloaded,
    validated, and discarded (since its version is known to be incompatible)
    during backtracking.
    
    This commit moves version deduplication of candidates from indexes to
    before the Candidate object is created, to avoid unneeded preparation.
    
    Note that we still need another round of deduplication in FoundCandidates
    to remove duplicated candidates when a distribution is already installed.
    uranusjr committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    79cbe6b View commit details
    Browse the repository at this point in the history