Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework our CI pipeline, to be purely GitHub Actions based #9759

Merged
merged 5 commits into from
Apr 2, 2021

Conversation

pradyunsg
Copy link
Member

Toward #7279
Closes #9087

AP hasn't been running on our recent PRs, Travis CI has "limited credits" that PyPA has had to ask for bumps to, and... GitHub Actions seems to just-work. We've already moved our MacOS workers and we have 20 workers for Linux+Windows; so might as well utilise them. :)

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 2, 2021
@pradyunsg
Copy link
Member Author

pradyunsg commented Apr 2, 2021

Differences from status quo:

@pradyunsg
Copy link
Member Author

FWIW, I plan on merging this in ~12-36 hours; since currently our CI pipelines aren't in a great shape and this is an improvement over status quo across the board (other than losing PyPy3 and a few Windows jobs, which we can add back in a follow up).

@pradyunsg
Copy link
Member Author

FWIW, I've updated the branch protection rules, such that this is the only PR that can be merged at the moment.

@pradyunsg
Copy link
Member Author

OK, so... I don't have the patience to wait 4 more hours here. I'm gonna merge this now. :)

I'm feeling fairly productive this morning and this is a significantly big improvement to our CI setup that help a lot with that.

@pradyunsg pradyunsg merged commit 6c87373 into pypa:main Apr 2, 2021
@uranusjr
Copy link
Member

uranusjr commented Apr 3, 2021

@pradyunsg None of the test runs are marked as required now. Is it intentional?

@pradyunsg
Copy link
Member Author

pradyunsg commented Apr 3, 2021

Is it intentional?

Yes, for now.

That's necessary since the runs get skipped if there's no code changes -- and in that case, their name doesn't show up in the checks -- see https://github.com/pypa/pip/actions/runs/711427044 from #9718's latest commit's checks. I don't have a good solution to this issue yet, but we're usually careful about merging PRs anyway; so it's fine for now.

@pradyunsg pradyunsg deleted the revamp-ci-apr-2021 branch April 3, 2021 08:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in Travis CI pricing model, turn it off?
2 participants