Fix some tests that are checking logs incorrectly #9780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
uranusjr
approved these changes
Apr 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are failing on my machine. They seem to be expecting certain log output, but are getting unexpected records. I don't know if that's because somehow a bug got released and the tests are actually wrong (the CI for the main branch seems broken at the moment) or if it's something weird on my PC¹. But this change fixes the issue, so it's probably worth having.
Obviously a better fix would be to work out why (and when) the tests started failing, and fix the root cause, but I don't have the time for that now, and I needed these fixes to get the test suite working again. I'm happy to withdraw this if someone wants to submit a proper fix.
¹ Running the test suite locally feels a bit like playing whack-a-mole with intermittent errors right now, and I've no idea why 🙁