Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendored dependencies #9813

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Update vendored dependencies #9813

merged 3 commits into from
Apr 20, 2021

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Apr 17, 2021

Closes #8887

@sbidoul sbidoul added this to the 21.1 milestone Apr 17, 2021
pradyunsg
pradyunsg reviewed Apr 17, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the automation made a mistake!

src/pip/_vendor/vendor.txt Outdated Show resolved Hide resolved
@sbidoul sbidoul force-pushed the update-vendored-20210417-sbi branch from 30171ce to f9a4485 Compare April 17, 2021 12:30
@pradyunsg
Copy link
Member

pradyunsg commented Apr 17, 2021 •
edited
Loading

c5dbbe7 doesn't remove the LICENSE.rst file for idna, while adding LICENSE.md file. We'd likely want to remove that file; as the CI check is trying to do.

@sbidoul
Copy link
Member Author

sbidoul commented Apr 17, 2021

c5dbbe7 doesn't remove the LICENSE.rst file for idna, while adding LICENSE.md file. We'd likely want to remove that file; as the CI check is trying to do.

Is that due to me running an old version of vendoring ?

@sbidoul sbidoul force-pushed the update-vendored-20210417-sbi branch from f9a4485 to d69a2d7 Compare April 17, 2021 14:36
@sbidoul
Copy link
Member Author

sbidoul commented Apr 18, 2021

Is that due to me running an old version of vendoring ?

It was.

@sbidoul sbidoul merged commit 88eb4f0 into pypa:main Apr 20, 2021
@sbidoul sbidoul deleted the update-vendored-20210417-sbi branch April 20, 2021 12:46
@pradyunsg
Copy link
Member

I just saw your question, and it seems like you discovered the answer on your own. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@pfmoore pfmoore pfmoore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.1
Development

Successfully merging this pull request may close these issues.

Upgrade vendored pep517 to 0.10.0 or later
3 participants
@sbidoul @pradyunsg @pfmoore