Cache location calculation functions #9865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
The practical difference is the mismatch detection is not performed at most once for every invocation, thus only warned once if there are any mismatches.
uranusjr
force-pushed
the
sysconfig-message-improvement
branch
from
ea85434
to
6123570
Compare
pradyunsg
approved these changes
Apr 26, 2021
|
Would it make sense to switch to |
|
I think we should probably remove the warnings altogether for now (from another discussion). I’ll write a separate PR for it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The practical difference is the mismatch detection is not performed at most once for every invocation, thus only warned once if there are any mismatches.