-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a better error message when uninstalling packages without dist-info/RECORD #9949
Conversation
Open question: What if INSTALLER says pip? In that case, the error would read:
And that is a bit silly. Should INSTALLER with pip in it be treated the same way as missing INSTALLER? |
The message should probably say something else if One possibility is to say declare the package outright broken and suggest re-installing it with |
That is getting rather complex and I am not sure I want to go that way. If |
I'm a little annoyed to think that we can't improve our users' experience by using a file that's explicitly designed to tell us when we manage an installation, just because some other project (conda in this case) is in violation of the standard. @uranusjr's suggestion seems like the right approach to me (yes, it's a bit passive aggressive towards conda but 🤷). If pip does own the installation, then |
Pushed a fixup commit for easier review (the intention is to squash it). |
…t-info/RECORD Fixes pypa#8954
2203bc8
to
f77649e
Compare
Squashed. |
Approved and CI passed. Ready to be merged? |
Is there anything I can do to help move this along? |
Thanks @pfmoore |
Fixes #8954