Skip to content

Commit

Permalink
Tweak crayons patch with vendored imports
Browse files Browse the repository at this point in the history
- Remove now-unused `allow_global` argument to pip install
  argument builder
- Update vistir version number and code to fix vendoring issue

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
  • Loading branch information
techalchemy committed May 20, 2020
1 parent 2c49876 commit ed780c4
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
3 changes: 1 addition & 2 deletions pipenv/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,6 @@ def get_pip_args(
no_deps=False, # type: bool,
selective_upgrade=False, # type: bool
src_dir=None, # type: Optional[str]
allow_global=False, # type: bool
):
# type: (...) -> List[str]
from .vendor.packaging.version import parse as parse_version
Expand Down Expand Up @@ -1496,7 +1495,7 @@ def pip_install(
pip_args = get_pip_args(
pre=pre, verbose=environments.is_verbose(), upgrade=True,
selective_upgrade=selective_upgrade, no_use_pep517=not use_pep517,
no_deps=no_deps, require_hashes=not ignore_hashes, allow_global=allow_global
no_deps=no_deps, require_hashes=not ignore_hashes,
)
pip_command.extend(pip_args)
if r:
Expand Down
4 changes: 2 additions & 2 deletions pipenv/patched/crayons.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
import re
import sys

import shellingham
import colorama
from pipenv.vendor import shellingham
from pipenv.vendor import colorama

PY3 = sys.version_info[0] >= 3

Expand Down
2 changes: 1 addition & 1 deletion pipenv/vendor/vendor.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ six==1.14.0
semver==2.9.0
toml==0.10.1
cached-property==1.5.1
vistir==0.5.1
vistir==0.5.2
pip-shims==0.5.2
contextlib2==0.6.0.post1
funcsigs==1.0.2
Expand Down
7 changes: 5 additions & 2 deletions pipenv/vendor/vistir/misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,11 +207,14 @@ def __init__(
stdout_allowed=False, # type: bool
):
# type: (...) -> None
stdout_encoding = None
stderr_encoding = None
preferred_encoding = getpreferredencoding()
if subprocess is not None:
stdout_encoding = self.get_subprocess_encoding(subprocess, "stdout")
stderr_encoding = self.get_subprocess_encoding(subprocess, "stderr")
self.stdout_encoding = stdout_encoding or PREFERRED_ENCODING
self.stderr_encoding = stderr_encoding or PREFERRED_ENCODING
self.stdout_encoding = stdout_encoding or preferred_encoding
self.stderr_encoding = stderr_encoding or preferred_encoding
self.stdout_lines = []
self.text_stdout_lines = []
self.stderr_lines = []
Expand Down
5 changes: 3 additions & 2 deletions tasks/vendoring/patches/patched/crayons.patch
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ index 455d3e90..de735daf 100644

-PY3 = sys.version_info[0] >= 3
-
+import shellingham
import colorama
-import colorama
+from pipenv.vendor import shellingham
+from pipenv.vendor import colorama

+PY3 = sys.version_info[0] >= 3
+
Expand Down

0 comments on commit ed780c4

Please sign in to comment.