Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalisation of package names in Pipfile is inconsistent. #1855

Closed
funkybob opened this issue Mar 27, 2018 · 2 comments
Closed

Capitalisation of package names in Pipfile is inconsistent. #1855

funkybob opened this issue Mar 27, 2018 · 2 comments
Labels
Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior.

Comments

@funkybob
Copy link

When I run "pipenv install {package}" all the package names in the Pipfile are lower-cased.

However, when I run "pipenv uninstall {package}" many of the names are changed back to their mixed case form.

This creates a lot of noise in change logs.

$ python -m pipenv.help

$ python -m pipenv.help output

Pipenv version: '11.9.0'

Pipenv location: '/home/curtis/.local/lib/python2.7/site-packages/pipenv'

Python location: '/usr/bin/python'

Other Python installations in PATH:

  • 2.7: /usr/bin/python2.7

  • 2.7: /usr/bin/python2.7

  • 3.4: /usr/bin/python3.4m

  • 3.4: /usr/bin/python3.4

  • 2.7.9: /usr/bin/python

  • 2.7.9: /usr/bin/python2

  • 3.4.2: /usr/bin/python3

PEP 508 Information:

{'implementation_name': 'cpython',
 'implementation_version': '0',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '3.16.0-5-amd64',
 'platform_system': 'Linux',
 'platform_version': '#1 SMP Debian 3.16.51-3+deb8u1 (2018-01-08)',
 'python_full_version': '2.7.9',
 'python_version': '2.7',
 'sys_platform': 'linux2'}

System environment variables:

  • PYTHONDONTWRITEBYTECODE
  • PGPASSWORD
  • LOGNAME
  • USER
  • HOME
  • PATH
  • PYTHONUNBUFFERED
  • LANG
  • TERM
  • SHELL
  • LANGUAGE
  • SHLVL
  • PGUSER
  • PYTHONPATH
  • PIP_PYTHON_PATH
  • _
  • SSH_CONNECTION
  • SSH_TTY
  • OLDPWD
  • SSH_CLIENT
  • PWD
  • MAIL
  • LS_COLORS

Pipenv–specific environment variables:

Debug–specific environment variables:

  • PATH: /usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
  • SHELL: /bin/bash
  • LANG: en_AU.UTF-8
  • PWD: /home/curtis/review_app/workspace/candle-server/src/components/erasmus


Expected result

Consistent casing for both install / uninstall.

Actual result
 flower = "*"
-flask = "*"
-flask-xml-rpc = "*"
-flask-restful = "*"
+Flask = "*"
+Flask-XML-RPC = "*"
+Flask-RESTful = "*"
 pytest-flask = "*"
@techalchemy techalchemy added Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior. labels Mar 27, 2018
@techalchemy
Copy link
Member

Seems to be occurring since #1314 -- as @ncoghlan suggested there we should just never alter what is in the Pipfile, but normalize it on the way in

@techalchemy
Copy link
Member

This is fixed in #1826 and released, sorry for the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Development

No branches or pull requests

2 participants