-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package name normalisation is flip-flopping #1314
Comments
I tracked it down to this change bb0719f. We used to verify casing when an install or uninstall action was performed. The install portion was short circuited so everything has been written as our pep423 format for normalization. When uninstall is run, it still writes names to the packages as the author intended. We need to choose one format or the other and then change this to work with it. |
+1 for using the package's canonical form. |
While the lock file should definitely use normalised forms,
So I think the key issue here is that neither |
Some packages like Jinja2 have multiple valid ways to write them. Depending on what you do, they flip-flop between them.
Describe your environment
$ python -V
3.6.4$ pipenv --version
9.0.1 and current masterExpected result
Package names in Pipfile stay constant.
Actual result
When installing Jinja2 becomes lowercase, when uninstalling any other package, it becomes uppercase.
Steps to replicate
Gives you:
gives you (as expected):
Now, if you run
You get a stack trace, which I will report in a different ticket. :)
But
now gives you:
Notice the capital “J”. As you can imagine, that’s rather annoying when checking in changes. :)
The text was updated successfully, but these errors were encountered: