Fix "update" command casing problem #1355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @senpos, this is actually a byproduct of a larger casing issue in pipenv. We're currently doing some investigation tracked in #1314. I think this may actually exacerbate the bad behaviour so I'm going to mark this as do not merge till we get to the bottom of what "correct" behaviour is. Then we can revisit merging. Thanks for putting this together! |
|
sorry for the close/reopen, had one too many things selected! |
|
Closing as we need to re-architect this portion of the code entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1316
all_packagesmethod now retrieves data from_pipfile, rather than_parsed_pipfile, which normalizes all package names from_parsed_pipfileupdatemethod now transformspackage_nameinto normalized one and then uses it for building response messages and removing/instaslling packageModifiyng
all_packagesmethod should not cause any problems, because it is used literally in two places and both of them are inupdatemethod.Actually, with these changes done to
all_packagesmethod, it can be also used inuninstallcommand, but probably you need to check healthiness of this PR first.