Pipenv install does not provide a good error message for no Pipfile. #2846

fossum · 2018-09-12T16:58:08Z

Issue description

When attempting to run pipenv install --dev in the wrong spot I got this error below (not a bug I assume).

~ # pipenv install --dev
Creating a Pipfile for this project...
Traceback (most recent call last):
  File "/usr/local/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.4/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.4/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.4/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.4/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.4/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.4/site-packages/pipenv/cli.py", line 435, in install
    selective_upgrade=selective_upgrade,
  File "/usr/local/lib/python3.4/site-packages/pipenv/core.py", line 1759, in do_install
    pypi_mirror=pypi_mirror,
  File "/usr/local/lib/python3.4/site-packages/pipenv/core.py", line 639, in ensure_project
    ensure_pipfile(validate=validate, skip_requirements=skip_requirements, system=system)
  File "/usr/local/lib/python3.4/site-packages/pipenv/core.py", line 288, in ensure_pipfile
    project.create_pipfile(python=python)
  File "/usr/local/lib/python3.4/site-packages/pipenv/project.py", line 576, in create_pipfile
    config_parser = ConfigOptionParser(name=self.name)
  File "/usr/local/lib/python3.4/site-packages/pipenv/patched/notpip/_internal/baseparser.py", line 141, in __init__
    assert self.name
AssertionError
~ #

Expected result

I would expect something about missing a Pipfile or some such. Probaly something along these lines.

AssertionError("Could not find Pipfile.")

Actual result

Instead I just got AssertionError().

Steps to replicate

mkdir foo
cd foo
pipenv install --dev

$ pipenv --support

Pipenv version: '2018.7.1'

Pipenv location: '/usr/local/lib/python3.4/site-packages/pipenv'

Python location: '/usr/local/bin/python'

Other Python installations in PATH:

3.4: /usr/local/bin/python3.4m
3.4: /usr/local/bin/python3.4
3.4: /usr/local/bin/python3.4
3.4.9: /usr/local/bin/python
3.4.9: /usr/local/bin/python
3.4.9: /usr/local/bin/python3
3.4.9: /usr/local/bin/python3

PEP 508 Information:

{'implementation_name': 'cpython',
 'implementation_version': '3.4.9',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '4.15.0-33-generic',
 'platform_system': 'Linux',
 'platform_version': '#36-Ubuntu SMP Wed Aug 15 16:00:05 UTC 2018',
 'python_full_version': '3.4.9',
 'python_version': '3.4',
 'sys_platform': 'linux'}

System environment variables:

PYTHONDONTWRITEBYTECODE
https_proxy
http_proxy
HOME
HTTPS_PROXY
LANG
PWD
no_proxy
PATH
HOSTNAME
PIP_PYTHON_PATH
OLDPWD
NO_PROXY
GPG_KEY
HTTP_PROXY
TERM
PYTHON_PIP_VERSION
SHLVL
PYTHON_VERSION

Pipenv–specific environment variables:

Debug–specific environment variables:

PATH: /usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG: C.UTF-8
PWD: /

Contents of Pipfile ('/Pipfile'):

The text was updated successfully, but these errors were encountered:

uranusjr · 2018-09-13T07:07:21Z

Contributions are welcomed. Just change the line in the traceback.

decentral1se · 2018-09-13T12:12:42Z

Oh yeah, just got bitten by this. Will attempt a fix!

fossum · 2018-09-19T17:20:33Z

I see the referenced PR #2853 isn't merged yet, but is the issue fixed already? Here is master:latest(19cc731)

➜  pipenv git:(master) ✗ mkdir ../pip-test
➜  pipenv git:(master) ✗ cd ../pip-test
➜  pip-test pipenv install --dev
Creating a virtualenv for this project…
Pipfile: /home/ericfoss/Development/pip-test/Pipfile
Using /usr/bin/python3 (3.6.5) to create virtualenv…
⠸Already using interpreter /usr/bin/python3
Using base prefix '/usr'
New python executable in /home/ericfoss/.local/share/virtualenvs/pip-test-1fL-zKVG/bin/python3
Also creating executable in /home/ericfoss/.local/share/virtualenvs/pip-test-1fL-zKVG/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /home/ericfoss/.local/share/virtualenvs/pip-test-1fL-zKVG
Creating a Pipfile for this project…
Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Updated Pipfile.lock (ca72e7)!
Installing dependencies from Pipfile.lock (ca72e7)…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/0 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
➜  pip-test

jr7square · 2018-10-04T02:23:11Z

I'll pick this up since the previous PR isn't merged.

jr7square · 2018-10-06T22:29:43Z

uh actually....yeah I don't see this issue is latest version as well, or at least I can't manage to replicate the error.

…o merge-prs - Closes #2920

techalchemy · 2018-10-31T05:43:33Z

ah this is merged now, thanks for reporting

frostming · 2018-11-20T15:06:46Z

When reviewing this issue. I found that the fix was not suitable because it didn't catch the real devil in the shadow. What is worse is that it introduced an API change which however didn't include a PEEP nor a changelog entry.

pipenv install is designed to create the Pipfile if it isn't present, but people are surprised by the error thrown #3260 now.

Looking at the stacktrace of this issue, the error occurs when pipenv attempts to create a Pipfile. The file was desired to be created successfully but something went wrong.

I will spend some time revisiting the errored codes and prepare a revert to this change.

techalchemy · 2018-11-20T15:51:00Z

@frostming-- don't "revert" the change, as in the git operation, simply fix the conditional logic

Also, don't hold your PR back for a full review, fix the known issue so we can move ahead. The specific behavior change is annoying, but is only going to affect manual installation processes and can be corrected or worked around by simply installing a package.

The error message is detailed, the change is minor, all that needs to happen is a minor adjustment in logic. It is not an intentional API change, it is a conditional logic issue.

techalchemy · 2018-11-20T15:59:37Z

Hm note that there actually is no problem with the exception logic and it is accurately raising an exception about a missing pipfile, which just failed to generate due to a completely separate issue. So the error occurs downstream of the creation, and is completely unrelated to and separate from it.

andb0t · 2019-09-03T12:28:03Z

Any update on this? I'm encountering the same error when installing pipenv in a fresh alpine dockerfile:

FROM alpine:latest

# install python3 and pipenv
RUN apk add --no-cache --virtual .build-deps g++ python3-dev libffi-dev openssl-dev \
    && apk add --no-cache --update python3 \
    && pip3 install --upgrade pip setuptools pipenv

Running this causes the error:

docker build -t pipenv-test .
docker run -it pipenv-test sh
pipenv shell

uranusjr added Type: Enhancement 💡 This is a feature or enhancement request. good first issue Issues suitable as a newcomer to get familiar with Pipenv! labels Sep 13, 2018

snowmanunderwater mentioned this issue Sep 14, 2018

fix_#2846 #2853

Closed

jr7square pushed a commit to jr7square/pipenv that referenced this issue Oct 5, 2018

Provide a good message for error described in issue pypa#2846

0f380b3

jr7square mentioned this issue Oct 5, 2018

Provide a good message for error described in issue #2846 #2920

Closed

jr7square referenced this issue in jr7square/pipenv Oct 6, 2018

Merge branch 'master' into fix#2846-good-error-message

53333aa

techalchemy referenced this issue in jr7square/pipenv Oct 30, 2018

Merge branch 'master' into fix#2846-good-error-message

e5da58b

techalchemy referenced this issue Oct 30, 2018

Merge remote-tracking branch 'pr2920/fix#2846-good-error-message' int…

62c24ea

…o merge-prs - Closes #2920

techalchemy pushed a commit that referenced this issue Oct 30, 2018

Provide a good message for error described in issue #2846

e8231dc

techalchemy closed this as completed Oct 31, 2018

This was referenced Nov 10, 2018

Installing editable dependency in empty dir gives unhelpful message #3206

Closed

Fix unexpected error when installing editable packages #3207

Closed

mcallaghan-bsm mentioned this issue Oct 11, 2019

pipenv "Creating a Pipfile for this project..." 'assert self.name' in ConfigOptionParser (lacks human readable error handling) #3986

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pipenv install does not provide a good error message for no Pipfile. #2846

Pipenv install does not provide a good error message for no Pipfile. #2846

fossum commented Sep 12, 2018

uranusjr commented Sep 13, 2018

decentral1se commented Sep 13, 2018

fossum commented Sep 19, 2018

jr7square commented Oct 4, 2018

jr7square commented Oct 6, 2018

techalchemy commented Oct 31, 2018

frostming commented Nov 20, 2018

techalchemy commented Nov 20, 2018

techalchemy commented Nov 20, 2018

andb0t commented Sep 3, 2019 •

edited

Loading

Pipenv install does not provide a good error message for no Pipfile. #2846

Pipenv install does not provide a good error message for no Pipfile. #2846

Comments

fossum commented Sep 12, 2018

Issue description

Expected result

Actual result

Steps to replicate

uranusjr commented Sep 13, 2018

decentral1se commented Sep 13, 2018

fossum commented Sep 19, 2018

jr7square commented Oct 4, 2018

jr7square commented Oct 6, 2018

techalchemy commented Oct 31, 2018

frostming commented Nov 20, 2018

techalchemy commented Nov 20, 2018

techalchemy commented Nov 20, 2018

andb0t commented Sep 3, 2019 • edited Loading

andb0t commented Sep 3, 2019 •

edited

Loading