Installing from git and specifying the platform or os raises an InvalidMarker error

[samfrench]

Issue description

When running pipenv install using Python3 and pipenv version 2018.11.14, if I specify a platform for a package from GitHub I get an InvalidMarker error.

python3.7/site-packages/pip/_vendor/packaging/markers.py", line 280, in __init__', '    raise InvalidMarker(err_str)', 'pip._vendor.packaging.markers.InvalidMarker: Invalid marker: \'sys_platform == \\\'linux\\\'"\', parse error at \'"\'']

The platform specifications work fine on other modules when not using a git repo.

Expected result

The packages to be able to be installed or ignored from GitHub depending if the platform matched. The same installation behaviour as the packages that are not from GitHub.

Steps to replicate

Pipfile with the platform matchers.

[[source]]
name = "pypi"
verify_ssl = true
url = "https://pypi.org/simple"

[requires]
python_version = "3"

[packages]
tweepy = { git = "https://github.com/tweepy/tweepy", markers="sys_platform == 'linux'" }
picamera = { version = "*", sys_platform = "== 'linux'" }

Using this without "markers" produced the same issue.

tweepy = { git = "https://github.com/tweepy/tweepy", sys_platform = "== 'linux'" }

I am on a Mac and using python 3.7.

[duplicate-issues]

Hey @samfrench,

We did a quick check and this issue looks very darn similar to

• #3248 - Incorrect index in lockfile
• #3247 - pipenv --three fails
• #3246 - Update manual

This could be a coincidence, but if any of these issues solves your problem then I did a good job 😄

If not, the maintainers will get to this issue shortly.

Cheers,
Your Friendly Neighborhood ProBot

[techalchemy]

Ah, technically VCS repos don't really have this capability when they aren't editable I guess. I can just turn the validation aspect of this off to fix it I believe

[samfrench]

@techalchemy, it seems the issue I raised is currently the expected behaviour. You make it sound simple to fix.

If git repos could allow markers to install or skip specific os or platforms, this would be ideal. Thank you for taking a look at this. I'll keep an eye on when the corresponding pr is merged.