Keep Outdated Doesn't Retain Markers #3659
Labels
Category: Dependency Resolution
Issue relates to dependency resolution.
Priority: Low
This item is low priority and may not be looked at in the next few release cycles.
Status: In Progress
This item is in progress.
Type: Bug 🐛
This issue is a bug.
Comments
techalchemy
added
Type: Bug 🐛
techalchemy
added a commit
that referenced
this issue
Mar 31, 2019
- Don't compare versions of editable dependencies when updating using `--keep-outdated` -- editable dependencies will now be updated to the latest version - Ensure we don't drop markers from the lockfile when versions are not updated - Fixes #3656 - Fixes #3659 Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
added a commit
that referenced
this issue
May 27, 2019
author Dan Ryan <dan@danryan.co> 1554074378 -0400 committer Dan Ryan <dan@danryan.co> 1558982736 -0400 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEb6jpcpb+5zzDideCsyDQTvvOpJUFAlzsMFAACgkQsyDQTvvO pJWZmRAAtge5wdprlLnKdWUYK5USZb7Uk3zJHi9UIvnO7nKP6UA/L2D/5nxZitvx pZI7cGG+8sLp2yZNtQZdW6LNM1jmRXgzdMLYQh/5zo5gbj6KLOw7erh0FU3L3uM6 wNBNM135Eqt7b+4a4C5TEK2UjwRxBHAsF+3ZzUy+UJQqgQEKxFVxW4gC4yxpfMtL jipE8ludwuOIM88ZJapmLpv2R6adQTxWZedTlmczdsy2/WKGHTCCpWs96PBbntdI pVBmoXfMhgZi+IuGR3iBYU0qS97vjJ8Te9tQZAaB9JGSqv3hHDWo1ht/rrG2RXzp 3i0Cf2vG4035EUh56VYE9FCC9m6Vu3U9iIR34BZG9K5+lDP7pmJmjT+GymEgMP0N GoP3LYUO+dJjMjaUEMsC6QIi6DAots3uk4lxIw3wcA4Im/N/i5xafsRj1Eu3UdBL wBDKMz/FQjH+tD+mnvTlzaxD5vdhhCdBu1gK59rjNMlzg8hz6EF61QbHCaQHd4UI VOGIa8ThLlLI3addxzq/McceAc+OsLJ9hm06jkjvvoIuKrHyE3DybdbYQC7uEwyw 2AvVuMDCPcciYQnkJhNTKmGvPcUDYD7cF91GKcUJKdPdyzDCeFEo5SUTKnLV4Cj2 VD2sdVUk4jnmYfE4pCFvHKYooxQDMKQk/VCKl1c9QHL9/ijCx+o= =b+H1 -----END PGP SIGNATURE----- Ensure resolver doesn't compare editable specifiers - Don't compare versions of editable dependencies when updating using `--keep-outdated` -- editable dependencies will now be updated to the latest version - Ensure we don't drop markers from the lockfile when versions are not updated - Fixes #3656 - Fixes #3659 Signed-off-by: Dan Ryan <dan@danryan.co> Add future import for print function Signed-off-by: Dan Ryan <dan@danryan.co> Handle all possible markers in lockfiles Signed-off-by: Dan Ryan <dan@danryan.co> Fix json import Signed-off-by: Dan Ryan <dan@danryan.co> point to correct reference for lockfile Signed-off-by: Dan Ryan <dan@danryan.co> Fix marker merging errors Signed-off-by: Dan Ryan <dan@danryan.co> Prevent automatically setting `editable=True` - Fixes #3647 Signed-off-by: Dan Ryan <dan@danryan.co> Add new feature toggle for VCS dependency resolution - Fixes #3577 Signed-off-by: Dan Ryan <dan@danryan.co> Fix syntax error Signed-off-by: Dan Ryan <dan@danryan.co> Use string for environment Signed-off-by: Dan Ryan <dan@danryan.co> Fix class name resolution for py27 Signed-off-by: Dan Ryan <dan@danryan.co> Write json files as unicode Signed-off-by: Dan Ryan <dan@danryan.co> Fix resolution with env var Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
added a commit
that referenced
this issue
May 27, 2019
author Dan Ryan <dan@danryan.co> 1554074378 -0400 committer Dan Ryan <dan@danryan.co> 1558982736 -0400 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEb6jpcpb+5zzDideCsyDQTvvOpJUFAlzsMFAACgkQsyDQTvvO pJWZmRAAtge5wdprlLnKdWUYK5USZb7Uk3zJHi9UIvnO7nKP6UA/L2D/5nxZitvx pZI7cGG+8sLp2yZNtQZdW6LNM1jmRXgzdMLYQh/5zo5gbj6KLOw7erh0FU3L3uM6 wNBNM135Eqt7b+4a4C5TEK2UjwRxBHAsF+3ZzUy+UJQqgQEKxFVxW4gC4yxpfMtL jipE8ludwuOIM88ZJapmLpv2R6adQTxWZedTlmczdsy2/WKGHTCCpWs96PBbntdI pVBmoXfMhgZi+IuGR3iBYU0qS97vjJ8Te9tQZAaB9JGSqv3hHDWo1ht/rrG2RXzp 3i0Cf2vG4035EUh56VYE9FCC9m6Vu3U9iIR34BZG9K5+lDP7pmJmjT+GymEgMP0N GoP3LYUO+dJjMjaUEMsC6QIi6DAots3uk4lxIw3wcA4Im/N/i5xafsRj1Eu3UdBL wBDKMz/FQjH+tD+mnvTlzaxD5vdhhCdBu1gK59rjNMlzg8hz6EF61QbHCaQHd4UI VOGIa8ThLlLI3addxzq/McceAc+OsLJ9hm06jkjvvoIuKrHyE3DybdbYQC7uEwyw 2AvVuMDCPcciYQnkJhNTKmGvPcUDYD7cF91GKcUJKdPdyzDCeFEo5SUTKnLV4Cj2 VD2sdVUk4jnmYfE4pCFvHKYooxQDMKQk/VCKl1c9QHL9/ijCx+o= =b+H1 -----END PGP SIGNATURE----- Ensure resolver doesn't compare editable specifiers - Don't compare versions of editable dependencies when updating using `--keep-outdated` -- editable dependencies will now be updated to the latest version - Ensure we don't drop markers from the lockfile when versions are not updated - Fixes #3656 - Fixes #3659 Signed-off-by: Dan Ryan <dan@danryan.co> Add future import for print function Signed-off-by: Dan Ryan <dan@danryan.co> Handle all possible markers in lockfiles Signed-off-by: Dan Ryan <dan@danryan.co> Fix json import Signed-off-by: Dan Ryan <dan@danryan.co> point to correct reference for lockfile Signed-off-by: Dan Ryan <dan@danryan.co> Fix marker merging errors Signed-off-by: Dan Ryan <dan@danryan.co> Prevent automatically setting `editable=True` - Fixes #3647 Signed-off-by: Dan Ryan <dan@danryan.co> Add new feature toggle for VCS dependency resolution - Fixes #3577 Signed-off-by: Dan Ryan <dan@danryan.co> Fix syntax error Signed-off-by: Dan Ryan <dan@danryan.co> Use string for environment Signed-off-by: Dan Ryan <dan@danryan.co> Fix class name resolution for py27 Signed-off-by: Dan Ryan <dan@danryan.co> Write json files as unicode Signed-off-by: Dan Ryan <dan@danryan.co> Fix resolution with env var Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Keep Outdated should retain any markers previously locked -- currently we are dropping markers when we lock
The text was updated successfully, but these errors were encountered: