Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Command to verify hash in Pipfile.lock against packages in Pipfile (out-of-date check) #4893

Closed
den4uk opened this issue Dec 10, 2021 · 3 comments
Labels
PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@den4uk
Copy link
Contributor

den4uk commented Dec 10, 2021

When running pipenv install --deploy, it checks the hash in the Pipfile.lock file matches with the packages in the Pipfile. Upon a mismatch, an exception is raised, else it proceeds to install.

NEW FEATURE: It would be very used to have the hash verification step to be a standalone command, which could return an exit code if the hash is verified or not.

User case.
This can come in useful in the CI/CD pipelines, where locking could be performed and committed when the hash is not verified. This could save a significant amount of time to avoid re-locking dependencies, especially when there are many of them.

@den4uk den4uk changed the title Command to verify hash in Pipfile.lock against packages in Pipfile only Feature: Command to verify hash in Pipfile.lock against packages in Pipfile (out-of-date check) Dec 10, 2021
@matteius
Copy link
Member

I agree that this would be a useful feature. Perhaps open a PR and we can push for it?

@den4uk
Copy link
Contributor Author

den4uk commented Dec 18, 2021

Thanks for a suggestion, I opened a PR for an initial review. #4896

@matteius matteius added Type: Enhancement 💡 This is a feature or enhancement request. PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. labels Dec 19, 2021
@matteius
Copy link
Member

This has been merged to master branch, congrats @den4uk ! Going to close this issue out for now, looking forward to the next release of pipenv 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

2 participants