Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: verify Pipfile.lock hash is up to date #4896

Merged
merged 5 commits into from
Feb 10, 2022

Conversation

den4uk
Copy link
Contributor

@den4uk den4uk commented Dec 18, 2021

This a proposal to have a new command added: pipenv verify

The aim is to be able to verify the hash in the Pipfile is up to date, or whether it needs updating.
The feature can be very useful within the CI/CD pipelines where the Pipfile.lock is a part of the repository and it needs to be up to date. The command can make it quick to run a check this is the case.

The PR is related to an open issue #4893

Copy link
Member

@matteius matteius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @den4uk -- this change looks correct to me.

@matteius
Copy link
Member

@den4uk Thanks for working on this, it currently requires more reviewers to chime in, but also I'm just realizing this should require some documentation and a news bit about its addition.

@den4uk
Copy link
Contributor Author

den4uk commented Jan 12, 2022

@den4uk Thanks for working on this, it currently requires more reviewers to chime in, but also I'm just realizing this should require some documentation and a news bit about its addition.

Hi @matteius , I thought this may need some documentation being added 😄
I will do this in due course, and once pushed you may be able to flag this with more reviewers, perhaps?

@oz123 oz123 merged commit 880f91c into pypa:main Feb 10, 2022
@den4uk den4uk deleted the verify-hash-command branch February 10, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants