Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce thamos verify command to check lockfile hash #971

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Dec 20, 2021

Related Issues and Dependencies

Related: pypa/pipenv#4896

This introduces a breaking change

  • No

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2021
@fridex
Copy link
Contributor Author

fridex commented Dec 20, 2021

/hold

... let's wait for upstream to see how they want to handle this (to be reasonably compatible).

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2021
@fridex fridex changed the title Introduce thamos verify command to check lockfile hash @fridex Introduce thamos verify command to check lockfile hash Dec 20, 2021
@fridex fridex marked this pull request as draft January 6, 2022 12:51
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2022
@fridex fridex marked this pull request as ready for review January 6, 2022 16:24
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2022
@fridex
Copy link
Contributor Author

fridex commented Jan 6, 2022

Ready to be reviewed. It looks like upstream is not active in reviewing the PR, but it might be worth having this subcommand available to users.

@fridex
Copy link
Contributor Author

fridex commented Jan 6, 2022

/assign @mayaCostantini

PTAL.

@mayaCostantini
Copy link
Contributor

lgtm 💯

@sesheta
Copy link
Member

sesheta commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@fridex
Copy link
Contributor Author

fridex commented Jan 6, 2022

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@sesheta sesheta merged commit cad3903 into thoth-station:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants