Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed vendored requests and certifi that are unused #5000

Closed
matteius opened this issue Mar 22, 2022 · 0 comments · Fixed by #5146
Closed

Removed vendored requests and certifi that are unused #5000

matteius opened this issue Mar 22, 2022 · 0 comments · Fixed by #5146
Assignees
@matteius
Labels
PR: awaiting-review The PR related to this issue is awaiting review by a maintainer.

Comments

@matteius
Copy link
Member

Pipenv coverage report shows that vendored requests and certifi that are unused. Upon further examination, we utilize the certifi from the vendored pip and not the one that we vendor, and requests library remains unused by pipenv internals -- just the tests which call out it out as part of the dev dependencies.

Issue description

Placeholder for PR.
@matteius matteius self-assigned this Mar 22, 2022
@matteius matteius mentioned this issue Mar 22, 2022
Closed
@matteius matteius added the Status: Deferred / On Hold 🛑 This item is on hold until further notice. label Apr 21, 2022
@matteius matteius mentioned this issue Jun 26, 2022
Merged
@matteius matteius added PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. and removed Status: Deferred / On Hold 🛑 This item is on hold until further notice. labels Jun 27, 2022
oz123 added a commit that referenced this issue Jul 5, 2022
@oz123
Remove charset_normalizer
6d0d0cd 
This was only used by requests which was removed in #5000
@oz123 oz123 mentioned this issue Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matteius matteius

Labels
PR: awaiting-review The PR related to this issue is awaiting review by a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 5000 remove requests certifi pypa/pipenv
1 participant
@matteius