Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping 3 windows tests in the CI now that we fixed the install return code #5064

Closed
matteius opened this issue Apr 21, 2022 · 0 comments · Fixed by #5163
Closed

Skipping 3 windows tests in the CI now that we fixed the install return code #5064

matteius opened this issue Apr 21, 2022 · 0 comments · Fixed by #5163
Labels
Category: Tests Relates to tests. OS: Windows This issue affects the Windows Operating System.

Comments

@matteius
Copy link
Member

Three tests fail in the Window CI runner now but now actually in windows when running locally in a terminal. After several hours of debugging, it was decided best to skip these three tests in windows for now and document this fact to follow up on getting them working in the CI for github actions the way they work in local windows.

Issue description

These tests are all in tests/integration/test_install_uri.py

  • test_editable_vcs_install
  • test_install_editable_git_tag
  • test_get_vcs_refs

Expected result

These should pass in Github actions Windows runner the way they can pass locally -- probably requires a code change somewhere and has to do with terminal output and maybe a lack of stdin in the CI.

Actual result

We skip those tests in the CI now:

#5046
@matteius matteius changed the title Have to skip 3 windows tests in the CI now that we fixed the install return code Skipping 3 windows tests in the CI now that we fixed the install return code Apr 21, 2022
matteius added a commit that referenced this issue Apr 21, 2022
@matteius
Fix install failures that silently pass (#5046)
5b3c55d 
* Check at the end of install if the failed dependency queue is empty or not and exit with error when there are still failed dependencies.

* Address PR feedback about crayons.

* Fix windows tests that fail because of showing the progress bar, but only local -- CI still breaks. 

* Skip these tests on the windows CI for now.   Created #5064 to track
@matteius matteius added OS: Windows This issue affects the Windows Operating System. and removed help wanted labels Jul 5, 2022
@matteius matteius mentioned this issue Jul 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Tests Relates to tests. OS: Windows This issue affects the Windows Operating System.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reenable these tests again on the Windows CI. pypa/pipenv
1 participant
@matteius