Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse libraries in pip own's _vendor #5174

Closed
oz123 opened this issue Jul 13, 2022 · 2 comments
Closed

Reuse libraries in pip own's _vendor #5174

oz123 opened this issue Jul 13, 2022 · 2 comments
Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.

Comments

@oz123
Copy link
Contributor

oz123 commented Jul 13, 2022

There are some libraries that we vendor, and are already found in pip/_vendor. These are;

colorma
tomli
urllib3
pyparsing
packaging
pep517
platformdirs
idna
distlib
six

Removing them from our own vendor is going to serve pipenv users with a smaller package and remove duplication.
It is also worth noting that most of these libraries are probably not going to be removed from pip since they are crucial for
parsing of dependencies.

Those who are not really related like tomli, colorama and urllib3 are crucial for other reasons and I also don't see them
being removed from pip anytime soon.

@oz123 oz123 added the Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. label Jul 13, 2022
oz123 added a commit that referenced this issue Jul 30, 2022
oz123 added a commit that referenced this issue Jul 31, 2022
oz123 added a commit that referenced this issue Jul 31, 2022
oz123 added a commit that referenced this issue Aug 1, 2022
@matteius
Copy link
Member

@oz123 Anything left on this one?

@oz123
Copy link
Contributor Author

oz123 commented Dec 20, 2022

These are still major tasks.
attrs is still an open issue. It's a large one though.
colorama is still open issue.
pyparsing.

Some other smaller libs are too ...

@matteius matteius closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Development

No branches or pull requests

2 participants