-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse libraries in pip own's _vendor #5174
Labels
Type: Vendored Dependencies
This issue affects vendored dependencies within pipenv.
Comments
oz123
added
the
Type: Vendored Dependencies
This issue affects vendored dependencies within pipenv.
label
Jul 13, 2022
oz123
added a commit
that referenced
this issue
Jul 30, 2022
oz123
added a commit
that referenced
this issue
Jul 30, 2022
oz123
added a commit
that referenced
this issue
Jul 31, 2022
oz123
added a commit
that referenced
this issue
Jul 31, 2022
oz123
added a commit
that referenced
this issue
Aug 1, 2022
@oz123 Anything left on this one? |
These are still major tasks. Some other smaller libs are too ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some libraries that we vendor, and are already found in
pip/_vendor
. These are;Removing them from our own vendor is going to serve pipenv users with a smaller package and remove duplication.
It is also worth noting that most of these libraries are probably not going to be removed from pip since they are crucial for
parsing of dependencies.
Those who are not really related like
tomli, colorama
andurllib3
are crucial for other reasons and I also don't see thembeing removed from pip anytime soon.
The text was updated successfully, but these errors were encountered: