Ensure version contains an operator when defined #5765
Conversation
|
All right, I kinda changed my though as I realized that get_version is called multiple time and that it was already handling Reusing regex defined in another module to ensure we have something like an operator and defaulting to "==" if not. @matteius What do you think ? |
| @@ -92,6 +92,23 @@ def test_install_without_dev(pipenv_instance_private_pypi): | |||
|
|
|||
| @pytest.mark.basic | |||
| @pytest.mark.install | |||
| def test_install_with_version_req(pipenv_instance_pypi): | |||
There was a problem hiding this comment.
I would recommend naming this test like: test_install_with_version_req_default_operator
There was a problem hiding this comment.
Done. Also fixed some failing test. Not sure how to trigger the CI again to check. Test are failing on main branch for me locally, trying to the get working , but right now not 100% sure I fixed them all
sebastien-coavoux
changed the title
|
https://github.com/pypa/pipenv/actions/runs/5445922252/jobs/9906282101 => macOS 3.8 is red. Trying to see how I can fix it |
|
@sebastien-coavoux Don't worry about that sporadic test failure, its unrelated to your change. |
|
@sebastien-coavoux Please add a news fragment but I think it looks good -- will add @oz123 for review. |
|
@matteius you mean update Changelog.rst right? |
No, that is generated from news fragments which get deleted from the news file. Go ahead and create a file in news |
|
I ran |
Try to fix #5764
Maybe not the best as it simply revert one line to avoid the crash. I've added a test to validate the fix
I believe there might be a better fix by concatenating a "default operator" to
_pipfile["version"]before calling the specifier constructor. I am just not sure of the intent of the whole function and which function should add this default operator.Requirement.parsefunction ?You have probably more knowledge on this to see if a default operator make sense. At least, we have a base to fix
@matteius Let me know