Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pip index handling #1004

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Conversation

hrbonz
Copy link
Contributor

@hrbonz hrbonz commented Oct 31, 2017

Fix handling of the proper long index option (--index-url) for pip install.

As far as I can tell, pip install uses -i and --index-url (see documentation), the pip search accepts --index long option. Those options are added by pip-tools when using pip-compile.

I'm wondering if the packages should not be associated with that index, following https://docs.pipenv.org/advanced.html#specifying-package-indexes

Change mentioned in #856

Example requirements.txt coming out of pip-compile:

--index-url https://pypi.example.com/xxx/+simple/
Django==1.9.5
myprivatepkg==1.1.5

fix handling of the proper long index option (--index-url) for pip
install.
Copy link
Sponsor Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nateprewitt nateprewitt merged commit 72767c7 into pypa:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants