In HackedPythonVersion, patch sys.version_info #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sigh |
nateprewitt
reviewed
Nov 16, 2017
| def __init__(self, python_version, python_path): | ||
| self.python_version = python_version | ||
| self.python_path = python_path | ||
|
|
||
| def __enter__(self): | ||
| os.environ['PIP_PYTHON_VERSION'] = str(self.python_version) | ||
| os.environ['PIP_PYTHON_PATH'] = str(self.python_path) | ||
| self.backup_version_info = sys.version_info |
There was a problem hiding this comment.
Is this being used by pip-tools or is it being added as a nice to have for use later?
There was a problem hiding this comment.
It's to reset sys.version_info outside of the context manager (in __exit__). We don't want that patched thing globally.
There was a problem hiding this comment.
Or was your question "Why are we patching sys.version_info? That's for pip to generate the right list of pep425 tags for wheel selection, i.e. Pick the right wheel for the right python version in the managed venv.
There was a problem hiding this comment.
Ok, that makes sense. Thanks for clarifying!
This is required to have pip/pip-tools get the right wheels according to the project virtualenv python version.
vphilippon
force-pushed
the
mock-sys-version
branch
from
bb21e93 to
f19ee42
Compare
|
🛬 Landing, thanks @vphilippon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to have pip/pip-tools get the right wheels according to
the project virtualenv python version.
Should completely fix #857, and the likes.
/cc @kennethreitz @erinxocon @nateprewitt @techalchemy