Make pew resolve workon home lazily #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1682. The problem is that pew resolves
workon_homeon import time, but we need to patch the lookup logic. This is fine when we run it with pexpect, but not when invoked programmatically. The environment variableWORKON_HOMEis changed too late for pew to pick up.The quick fix is to simply delay importing pew, but it is too unreliable and easy to break again in the future. In the end I decided to just change all
workon_homeoccurrences to function calls, so the value is resolved lazily, and can be patched whenever we want to.