-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we are not in a virtualenv if aborting #2181
Make sure we are not in a virtualenv if aborting #2181
Conversation
Thanks for the fix! The logic looks correct to me, but we probably want to add a comment there so make sure people reading the code in the future know exactly when (and why) we should abort. Would you be able to add this? |
Done! |
Thanks for the PR! Will merge after CI |
hey @techalchemy, is there a release planned for sometime soon that will get this live? |
@pegler in the next couple of days, we have some performance enhancements in the pipeline that I really want to get into the release if possible |
If i have the time I will release sooner, depends how smoothly these all go |
sounds good. thanks!! |
Fixes #2078