Add conversion methods for requires-python formats #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jun 18, 2018
| if c.requires_python: | ||
| # Old specifications had people setting this to single digits | ||
| # which is effectively the same as '>=digit,<digit+1' | ||
| if len(c.requires_python) == 1 and c.requires_python.isdigit(): |
There was a problem hiding this comment.
The len(c.requires_python) ==1 part looks redundant to me, just isdigit() is enough. It does not matter practically, but if Python ever gets to 10.0 we probably want to support that as well.
- Handle single-digit un-specified requires-python format - `Requires-Python: 3` should be functionally equivalent to `>=3,<4` - Fixes #2343 Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
2343-requires-python
branch
from
58c3f98 to
71ff857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires-Python: 3should be functionally equivalent to>=3,<4