Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipenv crashes #2388

Closed
wants to merge 5 commits into from
Closed

Fix pipenv crashes #2388

wants to merge 5 commits into from

Commits on Jun 20, 2018

  1. Fix cli option usage error 

    Fix IndexError exception when `more_packages` is empty and add the more
informal message for argument usage.

To reproduce this issue `pipenv install -e`
    @maxkrivich
    maxkrivich committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    e5ea0ed View commit details
    Browse the repository at this point in the history

  2. Fix empty indexes in cli param 

    Add extra check for -i option for fix `AttributeError: 'NoneType'`

To reproduce this bug `pipenv install <module> -i`
    @maxkrivich
    maxkrivich committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    40612f2 View commit details
    Browse the repository at this point in the history

  3. Change exception message

    @maxkrivich
    maxkrivich committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    d72f668 View commit details
    Browse the repository at this point in the history

  4. Update too complex if statement 

    Quick refactor for improve readability of code
    @maxkrivich
    maxkrivich committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    597fabd View commit details
    Browse the repository at this point in the history

  5. Fix CI errors

    @maxkrivich
    maxkrivich committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    7516ead View commit details
    Browse the repository at this point in the history