prettytoml: Catch StopIteration in AbstractTable._enumerate_items #2427
Conversation
hroncok
force-pushed
the
py37
branch
2 times, most recently
from
f4c6fa8
to
5e9d070
Compare
|
Ah yes. This is a bug I have attempted to patch for about 2 dozen times and I have no clue why it keeps unpatching itself... Virtualenv location: /tmp/pipenv-b9_Jcc-project/.venv
Creating a Pipfile for this project...
Pipfile.lock not found, creating...
Locking [dev-packages] dependencies...
Locking [packages] dependencies...
session=self.session,
File "/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/patched/notpip/_internal/index.py", line 180, in __init__
impl=implementation,
File "/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/patched/notpip/_internal/pep425tags.py", line 282, in get_supported
elif platform is None and is_manylinux1_compatible():
File "/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/patched/notpip/_internal/pep425tags.py", line 160, in is_manylinux1_compatible
return pip._internal.utils.glibc.have_compatible_glibc(2, 5)
NameError: global name 'pip' is not defined
/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/_compat.py:108: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/pipenv-ZMfLuA-requirements'>
warnings.warn(warn_message, ResourceWarning)
/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/_compat.py:108: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/pipenv-_pCZvZ-requirements'>
warnings.warn(warn_message, ResourceWarning)Note the |
|
What does change? |
|
uh... that's an interesting question... |
- return pip._internal.utils.glibc.have_compatible_glibc(2, 5)
+ return pipenv.patched.notpip._internal.utils.glibc.have_compatible_glibc(2, 5)is what I'm guessing it is supposed to say... |
|
testing with that. |
This makes PEP 479 enabled Pythons (such as 3.7) work again.
Otherwise you get:
RuntimeError: generator raised StopIteration
Fixes pypa#2426
|
I'm going to merge this tonight (since I assume the tests will pass on this) -- thanks for the fix. I'll add a 3.7 build as well so we can iterate and get that working before next week. Thanks for keeping an eye on us, seriously appreciated |
techalchemy
added
PR: awaiting-merge
|
How can I see the buildkite/pipenv CI result? |
|
Unfortunately Kenneth has that setup on a private account and they don't have the ability to make this publicly viewable yet, but it passed |
|
Someday appveyor will also run |
|
Thanks again! |
This makes PEP 479 enabled Pythons (such as 3.7) work again.
Otherwise you get:
Fixes #2426
Untested. The vendoring script fails with unrelated problem.