Fix subprocess usage for Python 2 #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techalchemy
reviewed
Jul 4, 2018
| @@ -59,8 +59,7 @@ def _handover(cmd, args): | |||
| if os.name != "nt": | |||
| os.execvp(cmd, args) | |||
| else: | |||
| proc = subprocess.run(args, shell=True, universal_newlines=True) | |||
| sys.exit(proc.returncode) | |||
| sys.exit(subprocess.call(args, shell=True, universal_newlines=True)) | |||
There was a problem hiding this comment.
Isn’t it better to PopenSpawn this? We vendor it with delegator
uranusjr
force-pushed
the
bugfix/shell-py27
branch
from
e728ba9
to
a1c5cb1
Compare
|
ok on discussion i think this is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2514.