Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update basics.rst with $SHELL. #2671

Merged
merged 9 commits into from
Aug 10, 2018
Merged

Update basics.rst with $SHELL. #2671

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9cb8e54
Update basics.rst with `$SHELL`
Jul 29, 2018
ddbec58
Merge pull request #1 from HopeForToday/improve-docs
Jul 29, 2018
0f30bcb
Update basics.rst
Aug 1, 2018
81a189d
Update basics.rst
Aug 2, 2018
0bddb1b
Merge branch 'master' into master
techalchemy Aug 4, 2018
c6742a8
Minor tense changes with basics.rst
Aug 7, 2018
c91cce1
Merge branch 'master' into master
Aug 7, 2018
6e6568e
Merge branch 'master' into master
techalchemy Aug 10, 2018
69d8a20
Merge branch 'master' into master
techalchemy Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/basics.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ You should do this for your shell too, in your ``~/.profile`` or ``~/.bashrc`` o

.. note:: The shell launched in interactive mode. This means that if your shell reads its configuration from a specific file for interactive mode (e.g. bash by default looks for a ``~/.bashrc`` configuration file for interactive mode), then you'll need to modify (or create) this file.

If you get something wrong with ``$ pipenv shell``, just check ``PIPENV_SHELL`` environment variable, ``$ pipenv shell`` will use it if available. For detail, see :ref:`configuration-with-environment-variables`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you get something wrong with

Can you change this to 'If you experience issues with`? Minor change but I think it's a tiny bit more natural.

just check PIPENV_SHELL environment variable

just check PIPENV_SHELL environment variable, $ pipenv shell just check the PIPENV_SHELL environment variable, which $ pipenv shell will use if available.

Minor tense changes mainly, thanks for contributing this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


☤ A Note about VCS Dependencies
-------------------------------
Expand Down Expand Up @@ -362,3 +363,4 @@ production environments for reproducible builds.
This will include all hashes, however (which is great!). To get a ``requirements.txt``
without hashes, use ``$ pipenv run pip freeze``.

.. _configuration-with-environment-variables:https://docs.pipenv.org/advanced/#configuration-with-environment-variables