Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best practice proposal: do not recommend --system for a Docker context #2762

Merged
merged 3 commits into from
Aug 29, 2018
Merged

Best practice proposal: do not recommend --system for a Docker context #2762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45b5e7d
Do not recommend --system for a Docker context
giorgiosironi Aug 20, 2018
7c512a5
Add news fragment for --system Docker recommendation
giorgiosironi Aug 20, 2018
418574f
Merge branch 'master' into do_not_recommend_no_virtualenv_in_docker
uranusjr Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/advanced.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ You can tell Pipenv to install a Pipfile's contents into its parent system with

$ pipenv install --system

This is useful for Docker containers, and deployment infrastructure (e.g. Heroku does this).
This is useful for managing the system Python, and deployment infrastructure (e.g. Heroku does this).

Also useful for deployment is the ``--deploy`` flag::

Expand Down
1 change: 1 addition & 0 deletions news/2762.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Stopped recommending `--system` for Docker contexts.