Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI to lean more heavily on click's built in functionality #2814

Merged
merged 23 commits into from
Sep 5, 2018
Merged

Refactor CLI to lean more heavily on click's built in functionality #2814

merged 23 commits into from
Sep 5, 2018

Commits on Sep 4, 2018

  1. Refactor CLI options 

    - Allow parsing of multiple packages, editable and non-editable, interspersed
- Handle `--index` and `--extra-index-url` with click's native parsing
- Split commonly used options out into separate groups
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    15916af View commit details
    Browse the repository at this point in the history

  2. Clean up core arguments 

    - Handle packages and editable packages separately
- Allow `pip_install` to take `Requirement` objects as arguments rather than re-parsing
- Remove bad parsing logic
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    eb18ed2 View commit details
    Browse the repository at this point in the history

  3. Update piptools patch 

    - Handle editable installs more effectively
- Actually store the distribution after we create it
- Actually get the dependencies from it
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    228b28b View commit details
    Browse the repository at this point in the history

  4. Clean up test

    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    7d57386 View commit details
    Browse the repository at this point in the history

  5. Refactor CLI for organization and simplicity 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    8b32e19 View commit details
    Browse the repository at this point in the history

  6. Cleanup unicode literals warnings 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    c3b6143 View commit details
    Browse the repository at this point in the history

  7. Fix some typos 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    305628e View commit details
    Browse the repository at this point in the history

  8. Clean up vcs ref checkouts 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    12217e6 View commit details
    Browse the repository at this point in the history

  9. Update requirementslib 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    597bc8c View commit details
    Browse the repository at this point in the history

  10. Fix lock -r output to include all markers 

    - Fixes #2748

Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    f93cefa View commit details
    Browse the repository at this point in the history

  11. Turn off no-deps for tarballs/zips 

    - Fixes #2173

Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    f902d8f View commit details
    Browse the repository at this point in the history

  12. Fix installation of multiple packages 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    eb0709b View commit details
    Browse the repository at this point in the history

  13. Minor project fixes 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    ab2b3d3 View commit details
    Browse the repository at this point in the history

  14. Add missing skip_lock option 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    86022cc View commit details
    Browse the repository at this point in the history

  15. Fix editor auto-deletions of piptools patch lines 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    2768edb View commit details
    Browse the repository at this point in the history

  16. No idea why this doesn't work

    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    e88d2d6 View commit details
    Browse the repository at this point in the history

  17. Syntax error... 

    Signed-off-by: Dan Ryan <dan@danryan.co>

Update requirementslib

Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    9cfb863 View commit details
    Browse the repository at this point in the history

  18. Reorganize pip installation to ditch custom parser 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    661eb17 View commit details
    Browse the repository at this point in the history

  19. Update requirementslib and fix VCS installation 

    Signed-off-by: Dan Ryan <dan@danryan.co>

Don't re-clone repos now that this works

Signed-off-by: Dan Ryan <dan@danryan.co>

Prune peeps directory from manifest

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix nonetype uris

Signed-off-by: Dan Ryan <dan@danryan.co>

Manually lock requirements?

Signed-off-by: Dan Ryan <dan@danryan.co>

Update requirementslib - leave context before updating sha

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix requirementslib vcs checkouts

Signed-off-by: Dan Ryan <dan@danryan.co>

fix tmpdir implementation

Signed-off-by: Dan Ryan <dan@danryan.co>

final fix for vcs uris

Signed-off-by: Dan Ryan <dan@danryan.co>

Allow for adding requirements objects directly to pipfile

Signed-off-by: Dan Ryan <dan@danryan.co>

Update piptools patch

Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    b33dfa6 View commit details
    Browse the repository at this point in the history

  20. Windows edge case and news 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    6f7dbe9 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'master' into fix-cli

    @kennethreitz
    kennethreitz committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    b4fa920 View commit details
    Browse the repository at this point in the history

  22. Fix option in cli and get released requirementslib 

    Signed-off-by: Dan Ryan <dan@danryan.co>
    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    b2110f9 View commit details
    Browse the repository at this point in the history

  23. Merge branch 'fix-cli' of github.com:pypa/pipenv into fix-cli

    @techalchemy
    techalchemy committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    69defdf View commit details
    Browse the repository at this point in the history