Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import error on Python 2.7 #2967

Closed
wants to merge 2 commits into from
Closed

Fix import error on Python 2.7 #2967

wants to merge 2 commits into from

Conversation

greyli
Copy link
Contributor

@greyli greyli commented Oct 9, 2018

Continue #2962
Close #2961 #2950

@greyli greyli mentioned this pull request Oct 9, 2018
Closed
@techalchemy
Copy link
Member

We have these vendored already, but the vendoring script isn’t rewriting imports properly (I think it only rewrites the patched directory). Most likely we need to fix this

techalchemy added a commit that referenced this pull request Oct 9, 2018
@techalchemy
Fix broken imports
160cb13 
- Add tempfile patch and news
- Fixes #2950
- Fixes #2955
- Fixes #2961
- Closes #2967

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this pull request Oct 9, 2018
Merged
@greyli greyli deleted the fix-import-error-on-py2 branch October 9, 2018 22:47
@gabrielfalcao gabrielfalcao mentioned this pull request Oct 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greyli @techalchemy