Fix trusted-host passthru #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techalchemy
added
Type: Bug 🐛
Signed-off-by: Dan Ryan <dan@danryan.co>
- Fix marker cleaning - Fixes #2979 Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
fix-trusted-hosts
branch
from
16c2a52
to
3ee8e11
Compare
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
orf
reviewed
Oct 10, 2018
| index_source = index_source.copy() | ||
| except SourceNotFound: | ||
| src_name = project.src_name_from_url(index) | ||
| verify_ssl = True if index not in trusted_hosts else False |
There was a problem hiding this comment.
You may have considered this already, but while I was testing the issue index was set to something like https://MY_INDEX:8080, whereas trusted_hosts was just a list like['MY_INDEX'].
There was a problem hiding this comment.
no I absolutely in no way was thinking about that, I should probably parse netlocs :D thanks for the comment!
techalchemy
added a commit
that referenced
this pull request
Oct 11, 2018
- Additional fix for #2981 Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
added a commit
that referenced
this pull request
Oct 11, 2018
- Additional fix for #2981 Signed-off-by: Dan Ryan <dan@danryan.co>
orf
reviewed
Oct 11, 2018
| sources.append({"url": extra_src}) | ||
| src_name = project.src_name_from_url(idx) | ||
| verify_ssl = True if idx not in trusted_hosts else False | ||
| extra_src = {"url": idx, "verify_ssl": verify_ssl, "name": extra_src} |
There was a problem hiding this comment.
I hate to do this to you, but extra_src is undefined here if the exception is triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix trusted-host passthru
--trusted-hostnot passed topipwhen installing from a lockfile #2979