Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEEP proposal for venv location #3024

Closed
wants to merge 1 commit into from
Closed

PEEP proposal for venv location #3024

wants to merge 1 commit into from

Conversation

gsemet
Copy link
Contributor

@gsemet gsemet commented Oct 14, 2018

Following #796, my humble proposal

@kennethreitz
Copy link
Contributor

this is out of scope.

@yuwash
Copy link

yuwash commented Jan 14, 2021

I indeed don’t see a necessity for PIPENV_INSTALL_VENV_DIR=custom/path or the corresponding --venv-dir, but the option --venv is basically the same as calling pipenv with PIPENV_VENV_IN_PROJECT=1, so I think that’s not a vastly new thing to the project. A short command-line argument is easier to use when it’s only needed on setup.

It might be better to name it --in-project though.

@gsemet
Copy link
Contributor Author

gsemet commented Jan 14, 2021

Now I would recommend a setting inside pipenv.toml that can be overridden by parameter.

It is always messy to let all users know they have to set this variable or create a .venv folder prior to do the pipenv install.

I use poetry now at least we can commit a setting in poetry.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants