-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --bare behavior to sync and clean #3064
Conversation
… an option to do_clean in cli.py
I only see it be added to |
--bare was an option for sync already in command.py, but I don't think it actually did anything. Sure thing I'll add a fragment. |
I see. Does the |
One change was made to sync that removes one output line (sync doesn't have much output either way). I can change the commit message and news fragment if you think it would be clearer. |
It would be best to either 1) remove mention of |
Great I'll change the fragment to: --bare now has an effect on clean, and sync's bare option is now used to reduce output. Should I squash commits as well? |
You don’t need to, I can squash on merge (but you can squash yourself as well, there’s no difference). |
- Closes #3064 Signed-off-by: Dan Ryan <dan@danryan.co>
Implement some behavior for --bare in sync and clean, and add bare an option to do_clean in cli.py
The issue
#3041
The fix
Added logic for --bare to sync and clean since they are passed in as arguments.
Excluding error messages.
Also added --bare as a click option to clean.
The checklist
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.