Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3102 - Converts output of subprocess to str in _pexpect_out #3103

Closed
wants to merge 1 commit into from
Closed

Issue #3102 - Converts output of subprocess to str in _pexpect_out #3103

wants to merge 1 commit into from

Conversation

aidin36
Copy link

@aidin36 aidin36 commented Oct 25, 2018

The issue

Issue #3102

The fix

Output of subprocess.after is not always a str, and cannot be concatenate to str. This PR converts the variable to str before concatenation.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@aidin36
Copy link
Author

aidin36 commented Oct 25, 2018

The error only happening in the master branch and not released yet, so I'm not sure if I should include a file in news.

@techalchemy
Copy link
Member

Hey there. Thanks for the PR. Things in the vendor folder unfortunately need to be modified with a corresponding patch or they will be dropped when we re-vendor the dependencies. For this specific case however the output it is giving in addition to strings is type instance which is an EOF object and can’t be stringified. There is an open PR in delegator and a corresponding one here to fix these issues

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants