Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PEEP for dedicated credential fields #3111

Closed
wants to merge 1 commit into from

Conversation

Vayel
Copy link

@Vayel Vayel commented Oct 27, 2018

Thank you for contributing to Pipenv!

The issue

#3085

The fix

Perhaps the fields username and password should only contain the name of an environment variable and not its value. Otherwise, the user can include the credentials in the Pipfile, which is a bad practice:

[[source]]
url = "https://mypypi.example.com/simple"
verify_ssl = true
name = "pypi"
username = "my#username"
password = "my/pass"

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@oz123
Copy link
Contributor

oz123 commented Jul 28, 2022

Rotten. Closings.

@oz123 oz123 closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rotten Status: Requires Approval This issue requires additional approval to move forward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants