Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PIPENV_SKIP_LOCK envvar, and suitable doc #3112

Closed
wants to merge 8 commits into from

Conversation

devxpy
Copy link
Contributor

@devxpy devxpy commented Oct 27, 2018

@techalchemy
Copy link
Member

As I said in the issue, isn’t this covered already by our use of auto_envvar_prefix?

@devxpy
Copy link
Contributor Author

devxpy commented Oct 29, 2018

@techalchemy. I am not sure, can you please tell me the env var to set, so that I can test it out myself?

@devxpy
Copy link
Contributor Author

devxpy commented Oct 30, 2018

Weird, search results don't seem to show any mention of auto_envvar_prefix

https://github.com/pypa/pipenv/search?q=auto_envvar_prefix&unscoped_q=auto_envvar_prefix

What am I missing here?

@techalchemy
Copy link
Member

The option I was looking for relates to this approved enhancement proposal which describes the implementation we plan to adopt which uses click's auto_envvar_prefix option which you can read about in click's documentation. I'd prefer to see a refactor in that direction than to keep adding environment variables that are manually defined and maintained.

@techalchemy
Copy link
Member

Seems like that option includes the command name in between, i.e. PIPENV_LOCK_SKIP_LOCK in order to work, so I'll include this

@devxpy
Copy link
Contributor Author

devxpy commented Nov 14, 2018

@techalchemy, Okay will merge master

@techalchemy
Copy link
Member

I merged your branch into the one I have queued up to merge already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants