Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not raise exception for pipenv graph when virtuanlenv is not created yet #3202

Merged

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented Nov 9, 2018

The issue

Fixes #3201

The fix

Catch exception and pass, let if not project.virtualenv_exists to handle it.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@techalchemy
Copy link
Member

Seems like a good idea, thanks!

@techalchemy techalchemy merged commit b96cd81 into pypa:master Nov 12, 2018
@jxltom jxltom deleted the friendly-info-when-no-virtualenv-for-graph branch November 13, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not raise exception for pipenv graph when virtualenv does not exist
2 participants