Derive missing values of source from existing fields #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this is one way to solve this issue. The other way is to provide default values in Pipfile.lock when converting Pipfile, which has missing fields, to Pipfile.lock. |
Signed-off-by: frostming <mianghong@gmail.com>
frostming
force-pushed
the
bugfix/3233
branch
from
5ce16a9
to
905c8c0
Compare
|
Thanks for the fix, I'm good with this... @jxltom I'm happy to add you as a maintainer BTW -- are you on slack at all? |
|
@techalchemy That will be awesome. Email |
|
We are on the PySlackers slack (https://pyslackers.com) — we just have a channel so I can’t invite you directly |
|
I'm in, already sent you a hello message 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_sslfrom URL parameter if not supplied@techalchemy @jxltom