Fix python path discovery if not called python #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techalchemy
force-pushed
the
bugfix/2783
branch
from
346af15
to
f63278a
Compare
frostming
reviewed
Mar 15, 2019
- Begin a refactor of `delegator.run` invocation to ensure we capture and handle failures with our own exception wrappers - Additoinally capture output and error logging and command information when running in verbose mode (should avoid significant repitition in the codebase) - Refactor `which` and `system_which` to fallback to pythonfinder's implementation - Abstract `is_python_command` to identify whether we are looking for python, this enables us to rely on `pythonfinder.Finder.find_all_python_versions()` to ensure we aren't skipping python versions - Fixes #2783 Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co> Update azure builds Signed-off-by: Dan Ryan <dan@danryan.co> Update azure pipeline windows code Signed-off-by: Dan Ryan <dan@danryan.co> Update python executable search for windows Signed-off-by: Dan Ryan <dan@danryan.co> Fix variable reference Signed-off-by: Dan Ryan <dan@danryan.co> Set virtual env variable on windows Signed-off-by: Dan Ryan <dan@danryan.co> globally install pipenv on windows Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co> Fix variable references Signed-off-by: Dan Ryan <dan@danryan.co> Fix variable references Signed-off-by: Dan Ryan <dan@danryan.co> Switch to powershell for windows virtualenv creation Signed-off-by: Dan Ryan <dan@danryan.co> use python version as path Signed-off-by: Dan Ryan <dan@danryan.co> use python version as path Signed-off-by: Dan Ryan <dan@danryan.co> swap variable name for python exe Signed-off-by: Dan Ryan <dan@danryan.co> add fallback for python exe Signed-off-by: Dan Ryan <dan@danryan.co> fix python variable setting Signed-off-by: Dan Ryan <dan@danryan.co> fix python variable setting Signed-off-by: Dan Ryan <dan@danryan.co> Use variable susbstitution for python executable location Signed-off-by: Dan Ryan <dan@danryan.co> Use activate script properly Signed-off-by: Dan Ryan <dan@danryan.co> Fix floating quote in python version Signed-off-by: Dan Ryan <dan@danryan.co> Don't block on safety call in python 2 as it overwrites output for some reason Signed-off-by: Dan Ryan <dan.ryan@xyleminc.com> Don't block on pipenv graph either Signed-off-by: Dan Ryan <dan@danryan.co> Check command return code instead of calling `block` Signed-off-by: Dan Ryan <dan@danryan.co> Don't load json after its already loaded Signed-off-by: Dan Ryan <dan@danryan.co> Wait on return code before checking contents Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
bugfix/2783
branch
from
4341023
to
116d085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix python path discovery if not called
pythondelegator.runinvocation to ensure we captureand handle failures with our own exception wrappers
when running in verbose mode (should avoid significant repitition in
the codebase)
whichandsystem_whichto fallback to pythonfinder'simplementation
is_python_commandto identify whether we are looking forpython, this enables us to rely on
pythonfinder.Finder.find_all_python_versions()to ensure we aren't skipping python versions
whichutility