Don't normalize name when writing Pipfile #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frost Ming <mianghong@gmail.com>
Signed-off-by: Frost Ming <mianghong@gmail.com>
Signed-off-by: Frost Ming <mianghong@gmail.com>
|
Approach gets a +1 from me |
techalchemy
added
the
PR: awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frost Ming mianghong@gmail.com
The fix
Don't canonicalize the name user passes in. Just make sure the name is safe. With that said, a package with dots in its name like
fsc.exportwon't be normalized tofsc-exportin PipfileCloses #3324
The impact
This PR doesn't fix the wrong package name which already exists in user's Pipfile. Taking the following examples:
requests-htmlrequests-html$ pipenv install Requests_HTMLrequests-html = "*"fsc.exportfsc-export$ pipenv install Fsc.Export"fsc.export" = "*"$ pipenv install fsc-exportThe checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.