Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the index names in lock file #3451

Merged
merged 4 commits into from
Jan 18, 2019
Merged

Update the index names in lock file #3451

merged 4 commits into from
Jan 18, 2019

Conversation

frostming
Copy link
Contributor

The issue

When Pipfile source name is changed and do pipenv lock the index names in lock file are not updated correctly

The fix

Only consider sources in Pipfile when locking, since the sources in lock file are not updated yet.
Fixes #3449

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

pipenv/utils.py Outdated Show resolved Hide resolved
@frostming frostming merged commit 943f828 into master Jan 18, 2019
@frostming frostming deleted the bugfix/3449 branch January 18, 2019 04:07
@techalchemy
Copy link
Member

Thanks! This area of the code needs some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The index name in Pipfile.lock don't update until lock again
3 participants